Simplify Royalty Claims in RoyaltyWorkflows and GroupingWorkflows by Removing Snapshots
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
sebsadface
force-pushed
the
update-royalty
branch
from
1c79b1a to
da5bcc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies
RoyaltyWorkflowsandGroupingWorkflowsto use the updated royalty vault API, introduced in PR#291 of the core protocol, which simplifies the royalty claiming process by removing the need for snapshots.Key Changes
RoyaltyWorkflows:transferToVaultAndSnapshotAndClaimBySnapshotBatchsnapshotAndClaimBySnapshotBatchsnapshotAndClaimByTokenBatchtransferToVaultAndSnapshotAndClaimBySnapshotBatchinRoyaltyWorkflowsto remove snapshot logic and renamed it totransferToVaultAndClaimByTokenBatch.claimAllRevenueinRoyaltyWorkflowsto allow claiming all available revenue for an ancestor IP.collectRoyaltiesAndClaimRewardinGroupingWorkflows.Test Plan
New test cases were added for the
claimAllRevenuefunction, and existing unit and integration tests forRoyaltyWorkflowsandGroupingWorkflowswere updated.Related Issue
RoyaltyWorkflowsandGroupingWorkflowsto Simplified Royalty Claiming Without Snapshots #112Notes
This PR introduces major interface changes to
RoyaltyWorkflows.