feat(story-nft): make StoryBadgeNFT upgradeable
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
kingster-will
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces upgradability for
StoryBadgeNFTthrough the beacon proxy pattern and renamesStoryNFTFactorytoOrgStoryNFTFactoryfor clarity and consistency.Key Changes
StoryBadgeNFTand refactored existing code to use these new storage struct.UPGRADEABLE_BEACONtoBaseOrgStoryNFTalong with agetBeaconfunction inIOrgStoryNFTandBaseOrgStoryNFT.deployOrgStoryNftanddeployOrgStoryNftByAdminto deployStoryBadgeNFTas aBeaconProxyof theUpgradeableBeacon, replacing the previous template cloning.UpgradeableBeacondeployment logic inDeployHelperand updated the upgrade script forStoryBadgeNFT.StoryNFTFactorytoOrgStoryNFTFactory, along with corresponding variable and function name updates.Test Plan
Refactored existing tests to align with these changes, and all tests pass locally. The deployment and upgrade functionalities of the beacon proxy were successfully tested on-chain. See the testnet transactions for verification:
storyBadgeNFTbeacon proxy: https://odyssey-testnet-explorer.storyscan.xyz/tx/0x53d17cbac79a221f88f7d634ec5fdfc358b24c6888a3b612b24fc9ad7c31729bstoryBadgeNFT: https://odyssey-testnet-explorer.storyscan.xyz/tx/0xe2c539d78c9cb58c4597836597d9171461fded29d3e2a2a33add3180f9575a25