refactor(story-nft): extract OrgNFT logic to BaseOrgStoryNFT
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
sebsadface
changed the title
OrgNFT logic in BaseStoryNFTOrgNFT Logic to BaseOrgStoryNFT
sebsadface
changed the title
OrgNFT Logic to BaseOrgStoryNFTOrgNFT logic to BaseOrgStoryNFT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
BaseStoryNFTby extractingOrgNFTlogic into a newly created child contract,BaseOrgStoryNFT, to enhance modularity and generalizability. Additionally, it introduces ERC-7201-compliant namespaced storage for bothBaseStoryNFTandBaseOrgStoryNFTfor future upgradability for inheriting contracts.Key Changes
orgNft,orgTokenId, andorgIpIdfromBaseStoryNFT’s constructor and initializer.BaseOrgStoryNFTas a child contract ofBaseStoryNFT, incorporatingorgNft,orgTokenId, andorgIpIdin its constructor and initializer, with relevant getters added.BaseStoryNFTandBaseOrgStoryNFT, including internal and external initializers.BaseStoryNFTto inherit from OpenZeppelin’s upgradable contracts.Test Plan
Refactored existing Story NFT test cases, all tests pass locally.