fix(registration): update dedup behavior

Author: sebsadface

contracts/lib/Errors.sol

@@ -14,6 +14,18 @@ library Errors {
     /// @notice Zero address provided as a param to the RegistrationWorkflows.
     error RegistrationWorkflows__ZeroAddressParam();
 
+    /// @notice Error thrown when attempting to mint an NFT with a metadata hash that already exists.
+    /// @param spgNftContract The address of the SPGNFT collection contract where the duplicate was detected.
+    /// @param tokenId The ID of the original NFT that was first minted with this metadata hash.
+    /// @param ipId The identifier of the registered IP associated with this NFT.
+    /// @param nftMetadataHash The hash of the NFT metadata that caused the duplication error.
+    error RegistrationWorkflows__DuplicatedNFTMetadataHash(
+        address spgNftContract,
+        uint256 tokenId,
+        address ipId,
+        bytes32 nftMetadataHash
+    );
+
     ////////////////////////////////////////////////////////////////////////////
     //                         LicenseAttachmentWorkflows                     //
     ////////////////////////////////////////////////////////////////////////////

contracts/workflows/RegistrationWorkflows.sol

@@ -125,7 +125,13 @@ contract RegistrationWorkflows is
             dedup: dedup
         });
 
-        if (deduped) return (_getIpId(spgNftContract, tokenId), tokenId);
+        if (deduped)
+            revert Errors.RegistrationWorkflows__DuplicatedNFTMetadataHash({
+                spgNftContract: spgNftContract,
+                tokenId: tokenId,
+                ipId: _getIpId(spgNftContract, tokenId),
+                nftMetadataHash: ipMetadata.nftMetadataHash
+            });
 
         ipId = IP_ASSET_REGISTRY.register(block.chainid, spgNftContract, tokenId);
         MetadataHelper.setMetadata(ipId, address(CORE_METADATA_MODULE), ipMetadata);

test/workflows/RegistrationWorkflows.t.sol

@@ -67,7 +67,11 @@ contract RegistrationWorkflowsTest is BaseTest {
         });
     }
 
-    function test_RegistrationWorkflows_mintAndRegisterIP_dedup() public withCollection whenCallerHasMinterRole {
+    function test_RegistrationWorkflows_revert_duplicatedNftMetadataHash()
+        public
+        withCollection
+        whenCallerHasMinterRole
+    {
         mockToken.mint(address(caller), 1000 * 10 ** mockToken.decimals());
         mockToken.approve(address(nftContract), 1000 * 10 ** mockToken.decimals());
 
@@ -82,18 +86,21 @@ contract RegistrationWorkflowsTest is BaseTest {
         assertEq(nftContract.tokenURI(tokenId1), string.concat(testBaseURI, ipMetadataDefault.nftMetadataURI));
         assertMetadata(ipId1, ipMetadataDefault);
 
-        (address ipId2, uint256 tokenId2) = registrationWorkflows.mintAndRegisterIp({
+        vm.expectRevert(
+            abi.encodeWithSelector(
+                Errors.RegistrationWorkflows__DuplicatedNFTMetadataHash.selector,
+                address(nftContract),
+                tokenId1,
+                ipId1,
+                ipMetadataDefault.nftMetadataHash
+            )
+        );
+        registrationWorkflows.mintAndRegisterIp({
             spgNftContract: address(nftContract),
             recipient: u.bob,
             ipMetadata: ipMetadataDefault,
             dedup: true
         });
-
-        // check that the tokenId is the same as the first one
-        assertEq(tokenId2, tokenId1);
-        assertTrue(ipAssetRegistry.isRegistered(ipId2));
-        assertEq(nftContract.tokenURI(tokenId2), string.concat(testBaseURI, ipMetadataDefault.nftMetadataURI));
-        assertMetadata(ipId2, ipMetadataDefault);
     }
 
     function test_RegistrationWorkflows_mintAndRegisterIp_publicMint() public {