Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing IP Account #73

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Introducing IP Account #73

merged 3 commits into from
Aug 25, 2023

Conversation

kingster-will
Copy link
Contributor

@kingster-will kingster-will commented Aug 21, 2023 •
edited
Loading

Introducing IP Account

See details in #70

Will add tests.

Closes #70

@Ramarti
Copy link
Contributor

Ramarti commented Aug 21, 2023

Code looks good, but I think it would be more in line with our Guidelines to have the tests in the same PR.

@kingster-will
Copy link
Contributor Author

Code looks good, but I think it would be more in line with our Guidelines to have the tests in the same PR.

Yeah, sounds good. added tests into the same PR.

leeren
leeren approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@leeren leeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kingster-will kingster-will merged commit 40bfd5c into main Aug 25, 2023
@LeoHChen LeoHChen deleted the ipaccount branch September 13, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeren leeren leeren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UIPA: Unified Intellectual Property Asset Account
3 participants
@kingster-will @Ramarti @leeren