Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update tuple types for sasl option #78

Merged
merged 2 commits into from
Dec 26, 2023
Merged

fix: update tuple types for sasl option #78

merged 2 commits into from
Dec 26, 2023

Conversation

btkostner
Copy link
Contributor

The sasl option for producers and consumers should be {:atom, :string, :string} instead of {:string, :string, :string} to match Brod and all documentation.

@btkostner btkostner self-assigned this Dec 26, 2023
@btkostner btkostner requested a review from a team as a code owner December 26, 2023 19:38
yordis
yordis previously approved these changes Dec 26, 2023
@btkostner btkostner changed the base branch from code-freeze/2023-2 to main December 26, 2023 19:42
@btkostner btkostner dismissed yordis’s stale review December 26, 2023 19:42

The base branch was changed.

@yordis yordis enabled auto-merge (squash) December 26, 2023 19:49
@yordis yordis disabled auto-merge December 26, 2023 19:49
@btkostner btkostner merged commit 2860d8b into main Dec 26, 2023
@btkostner btkostner deleted the sasl-fix branch December 26, 2023 19:51
btkostner pushed a commit that referenced this pull request Dec 26, 2023
An automated release has been created for you.
---


## [3.0.2](v3.0.1...v3.0.2)
(2023-12-26)


### Bug Fixes

* Update tuple types for sasl option
([#78](#78))
([2860d8b](2860d8b))


### Miscellaneous

* Set main branch for release please
([c8764b0](c8764b0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants