Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use :name option for DynamicSupervisor.start_link calls #46

Closed
wants to merge 1 commit into from

Conversation

seungjinstord
Copy link
Contributor

Checklist

Problem

We have had incidents where consumer lag spikes, and this is to implement a recommendation from comment:

derekkraan/horde#256

Details

Add the option on the start_link as indicated by the comment in the github issue in Horde's repo.

@seungjinstord seungjinstord self-assigned this Dec 2, 2024
@seungjinstord
Copy link
Contributor Author

Actually have to change it in wms-service as I misread the implementation in the github repo's issue.
I have to tweak the instantiation of Horde.DynamicSupervisor (start_link) - I was tweaking start_child

@kinson kinson deleted the horde-name-for-telemetry-warning-log branch December 2, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants