Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.0 #55

Merged
merged 135 commits into from
Jan 24, 2024
Merged

v0.4.0 #55

merged 135 commits into from
Jan 24, 2024

Conversation

jhollway
Copy link
Collaborator

@jhollway jhollway commented Jan 23, 2024

Description

2023-12-24

Package

  • Major overhaul of documentation
    • Moved function description up so that it appears in tooltips
    • Split documentation of many functions to provide more space for explanation
    • Moved some functions around for more thematic documentation
  • Added pkg_data() to report an overview of data contained within the package(s)
  • Updated README and DESCRIPTION with new organisational affiliation: stocnet/manynet
  • Updated tests to be consistent with future {ggplot2} release

Making

  • Migrated play_diffusion() and play_diffusions() from {migraph}
    • Including class creation, and print(), summary(), and plot() methods
  • Migrated play_learning() and play_segregation() from {migraph}
    • Including class creation, and print(), summary(), and plot() methods
  • Fixed bug in create_tree() where it was not returning a two-mode network correctly

Modifying

  • Added as_diffusion() to coerce a table of diffusion events into diff_model class
    • as_*() functions are now considered modifications
  • Completed a full range of tidy verbs for nodes
    • Added mutate_nodes()
    • Added filter() and filter_nodes()
    • Added rename_nodes()
  • Completed a full range of tidy and igraph verbs for ties
    • Added bind_ties()
    • Added delete_ties()
  • Added to_tree() to find one or more spanning trees amongst a network's ties
  • Added from_ties() to collect multiple networks into a multiplex network

Marking

  • Renamed is.igraph() to is_igraph() for igraph v2.0.0
  • Added is_list() for identifying a list of networks
  • Migrated node_is_core(), node_is_cutpoint(), node_is_fold(), node_is_isolate(), node_is_mentor() from {migraph}
  • Migrated node_is_exposed(), node_is_infected(), node_is_latent(), node_is_recovered() from {migraph}
  • Migrated node_is_max(), node_is_min(), node_is_random() from {migraph}
  • Migrated tie_is_bridge(), tie_is_loop(), tie_is_multiple(), tie_is_reciprocated() from {migraph}
  • Added tie_is_feedback()
  • Migrated tie_is_max(), tie_is_min() from {migraph}
  • Added tie_is_random()

Mapping

Data

  • Renamed ison_konigsberg to ison_koenigsberg and named the bridges
  • ison_algebra now in long multiplex format
  • ison_karateka now weighted, anonymous members are named by number, and "obc" variable renamed "allegiance"
  • ison_lawfirm enlarged from 36 to 71 nodes and now consists of three multiplex, directed networks
  • ison_southern_women names are now title case
  • Added ison_hightech, a multiplex, directed network from Krackhardt 1987
  • Added four ison_monastery datasets, three of which are signed and weighted, and the other is longitudinal, from Sampson 1969 (closes Add Sampson network data for testing and illustration purposes #49)
  • Added six ison_potter datasets in a list of networks, from Bossaert and Meidert 2013 (closes Add Harry Potter data #47)
  • Added ison_usstates data on the contiguity of US states, from Meghanathan 2017

Checklist:

  • PR form
    • Description above itemizes changes under subtitles, e.g. "## Data""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Longer functions are commented inline or broken down into helper functions so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

henriquesposito and others added 30 commits December 18, 2023 12:26
…helvetica" as base font. Updated theme family of functions to keep font consistent throuought theme.
…es Tutte theorem to identify perfect matching in one-mode networks
…e' is a reserved attribute for ties now too, this allows 'weight' to operate as a reserved tie attribute too, instead of just as values
… includes tip for identifying distinct datasets
…s by default when there are many frames. The "frames" argument was also added.
@jhollway jhollway self-assigned this Jan 23, 2024
Copy link
Contributor

@henriquesposito henriquesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for all the work with tidying up the documentation in the package @jhollway , I think it is much better and more consistent. I left a few comments, happy to adress them myself if you would like me to. Thank you.

@jhollway jhollway changed the title v1.0.0 v0.4.0 Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 675 lines in your changes are missing coverage. Please review.

Comparison is base (a1769d4) 53.46% compared to head (869ebc6) 47.94%.
Report is 136 commits behind head on main.

❗ Current head 869ebc6 differs from pull request most recent head 17b07f4. Consider uploading reports for the commit 17b07f4 to get more accurate results

Files Patch % Lines
R/mark_nodes.R 13.97% 117 Missing ⚠️
R/class_diff_model.R 6.12% 92 Missing ⚠️
R/make_play.R 40.41% 87 Missing ⚠️
R/make_read.R 62.63% 71 Missing ⚠️
R/map_autographr.R 20.22% 71 Missing ⚠️
R/pkg_tutorials.R 0.00% 39 Missing ⚠️
R/manip_as.R 11.11% 32 Missing ⚠️
R/map_theme.R 44.23% 29 Missing ⚠️
R/class_marks.R 22.58% 24 Missing ⚠️
R/mark_is.R 40.00% 21 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   53.46%   47.94%   -5.53%     
==========================================
  Files          22       27       +5     
  Lines        3056     3604     +548     
==========================================
+ Hits         1634     1728      +94     
- Misses       1422     1876     +454     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhollway jhollway merged commit 2e1269b into main Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment