-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torques bug fixes #29
Conversation
…e and add test to check if positions have been set before Mdot to prevert soft failures or obscure cuda memory bug
… about sign conventions
I do not think your solution is a good idea. It is introducing a lot of noise into the interface. |
…ctions" This reverts commit bd4e32f. Being done to implement a different method for preventing this error.
@RaulPPelaez I think (hope) this is good to go! I added the positions check on a per-solver basis which involved pretty minimal changes to most interfaces- good call. In the process, I refactored a bunch of the testing boilerplate code which added a couple new parameterizations that we had missed. I found an interesting potential bug in the NBody wall kernel that I'm going to open up a separate issue for |
This is great, thanks Ryker! |
Random collection of bug fixes that I found in my notes.
One important one is that if a mobility function (Mdot, hydrodynamicVelocities, and sqrtMdotW) is called before positions are set, some solvers would throw inscrutable errors. For example, NBody would throw a CUDA memory allocation error. Even though it says you have to call setPosistions first, I wanted to put a more descriptive error in there.
@RaulPPelaez The way I fixed the above bug was a bit gross and involved a getter and setter for a boolean variable in the MobilityInterface. Let me know if you have a better way to fix it!