Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONTokener getter/setter for JSONParserConfiguration needs work #941

Closed
stleary opened this issue Jan 12, 2025 · 2 comments
Closed

JSONTokener getter/setter for JSONParserConfiguration needs work #941

stleary opened this issue Jan 12, 2025 · 2 comments

Comments

@stleary
Copy link
Owner

stleary commented Jan 12, 2025

The 20250107 release of the strictMode feature includes JSONTokener getter and setter methods for the JSONParserConfiguration instance. These methods are no longer needed since the config instance has been added to the JSONTokener constructor. In particular, the setter could allow a developer to introduce unexpected behavior. Other solutions may be possible, but the following is recommended:

Getter: Annotate @deprecated. Otherwise, it's probably harmless, no change.
Setter: Annotate @deprecated. Consider silently ignoring the param if it is null.

@marilynel
Copy link

Working on issue: setter to be @deprecated, getter to be left alone

@stleary
Copy link
Owner Author

stleary commented Feb 10, 2025

Closing due to fixed in #949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants