Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment correlation algorithm, remove flattening of Velocity observable #369

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

harveydevereux
Copy link
Collaborator

@harveydevereux harveydevereux self-assigned this Dec 12, 2024
@ElliottKasoar ElliottKasoar added the documentation Improvements or additions to documentation label Dec 13, 2024
Copy link
Member

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but otherwise I think this looks good!

We probably want to change the title slightly to reflect the code changes, since it's not just changes to the docs.

janus_core/processing/correlator.py Outdated Show resolved Hide resolved
alinelena
alinelena previously approved these changes Jan 8, 2025
@ElliottKasoar ElliottKasoar linked an issue Jan 8, 2025 that may be closed by this pull request
@harveydevereux harveydevereux changed the title Comment correlation algorithm. Comment correlation algorithm, remove flattening of Velocity observable Jan 10, 2025
@ElliottKasoar
Copy link
Member

Looks good, thanks @harveydevereux!

@ElliottKasoar ElliottKasoar merged commit b727ff3 into stfc:main Jan 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add description to observables code
3 participants