Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#454 Create file in pytest's tmpdir, not in /tmp. #455

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Nov 28, 2024

Use pytest tmpdir (which is cleaned up automatically), instead of /tmp for temporary files (over 220 files per test run). Fixes #454.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.14%. Comparing base (44dd1f8) to head (156747f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   92.14%   92.14%   -0.01%     
==========================================
  Files          86       86              
  Lines       13840    13834       -6     
==========================================
- Hits        12753    12747       -6     
  Misses       1087     1087              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Joerg. I confirm that running the test suite no longer puts files straight into /tmp.
No other updates required.
Will proceed to merge.

@arporter arporter added ready for merge PR is waiting on final CI checks before being merged. and removed under review labels Nov 28, 2024
@arporter arporter merged commit 3bc75fe into master Nov 28, 2024
6 checks passed
@arporter arporter deleted the 454_dont_create_files_in_tmpdir_but_in_tmp_pytest branch November 28, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge PR is waiting on final CI checks before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fparser creates many files in /tmp
2 participants