Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket Word Cloud Generation Script #91

Merged
merged 12 commits into from
Dec 6, 2023
Merged

Conversation

charlieDurnsfordHollands
Copy link
Contributor

Create a script to generate a word cloud from the tickets in a queue. Requirements can be seen here.

@charlieDurnsfordHollands charlieDurnsfordHollands marked this pull request as ready for review August 16, 2023 08:27
Copy link
Collaborator

@anish-mudaraddi anish-mudaraddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial Review - Haven't looked at tests as the requested changes will likely change it.
Mostly good - but issue_filter could really do with being a dataclass - I can walk you though what they are and how to use them if you want

Copy link
Collaborator

@DavidFair DavidFair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to save us hassle in the future
@anish-mudaraddi if you want to make the changes I'd be happy to merge since it's us just removing duplicated info rather than changing

.github/workflows/word_cloud_generator.yaml Outdated Show resolved Hide resolved
word_cloud_generator/readme.md Show resolved Hide resolved
khalford
khalford previously approved these changes Nov 21, 2023
word_cloud_generator/word_cloud_generator.py Outdated Show resolved Hide resolved
word_cloud_generator/word_cloud_generator.py Show resolved Hide resolved
word_cloud_generator/word_cloud_generator.py Outdated Show resolved Hide resolved
word_cloud_generator/word_cloud_generator.py Outdated Show resolved Hide resolved
word_cloud_generator/word_cloud_generator.py Outdated Show resolved Hide resolved
word_cloud_generator/word_cloud_generator.py Outdated Show resolved Hide resolved
word_cloud_generator/word_cloud_generator.py Outdated Show resolved Hide resolved
word_cloud_generator/word_cloud_generator.py Outdated Show resolved Hide resolved
@DavidFair
Copy link
Collaborator

@khalford Would it be possible to get you to do these changes

@khalford khalford mentioned this pull request Dec 6, 2023
@DavidFair DavidFair merged commit 3d4eb29 into master Dec 6, 2023
3 checks passed
@khalford khalford deleted the wordcloud_generator branch September 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants