BUG: Fall back to image metadata for invalid entries #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fall back to the image's metadata if the VM has invalid entries set by the user. If they've got this partially incorrect we could still crash out (e.g. some sort of RL8 + RL9 personality) however it's hard to pre-validate every combo so cross that bridge later. In these cases where they're obvious wrong values we can simply ignore them and stick with the existing image values instead.
Slim down the override by moving checks into their own private static method without changing the implementation.
khalford
approved these changes
Dec 4, 2024
khalford
requested review from
a team,
dev-0pz and
Barfy007JB1
and removed request for
dev-0pz
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 96.48% 96.93% +0.45%
==========================================
Files 30 16 -14
Lines 2160 1175 -985
==========================================
- Hits 2084 1139 -945
+ Misses 76 36 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Barfy007JB1
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fall back to the image's metadata if the VM has invalid entries set by the user. If they've got this partially incorrect we could still crash out (e.g. some sort of RL8 + RL9 personality) however it's hard to pre-validate every combo so cross that bridge later.
In these cases where they're obvious wrong values we can simply ignore them and stick with the existing image values instead.