Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud chatops docker secrets #172

Merged
merged 14 commits into from
Sep 24, 2024
Merged

Cloud chatops docker secrets #172

merged 14 commits into from
Sep 24, 2024

Conversation

khalford
Copy link
Member

@khalford khalford commented Sep 19, 2024

Created a docker deployment for Cloud Chatops. Uses GitHub Actions as CD to build and push dev/prod images. Uses watchtower to keep the Cloud Chatops container up to date.

Unit tests and code "de-duplication" to be done/fixed in future PRs

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.47%. Comparing base (7394c9a) to head (e08da95).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cloud_chatops/src/read_data.py 62.50% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7394c9a) and HEAD (e08da95). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (7394c9a) HEAD (e08da95)
6 4
rabbit_consumer 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #172       +/-   ##
===========================================
- Coverage   96.82%   76.47%   -20.36%     
===========================================
  Files          69        3       -66     
  Lines        3120       85     -3035     
===========================================
- Hits         3021       65     -2956     
+ Misses         99       20       -79     
Flag Coverage Δ
rabbit_consumer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RWhiting78
RWhiting78 previously approved these changes Sep 20, 2024
RWhiting78
RWhiting78 previously approved these changes Sep 20, 2024
.github/workflows/cloud_chatops.yaml Outdated Show resolved Hide resolved
.github/workflows/cloud_chatops.yaml Outdated Show resolved Hide resolved
.github/workflows/cloud_chatops.yaml Outdated Show resolved Hide resolved
cloud_chatops/.pylintrc Outdated Show resolved Hide resolved
cloud_chatops/.pylintrc Outdated Show resolved Hide resolved
cloud_chatops/Dockerfile Outdated Show resolved Hide resolved
cloud_chatops/compose.yaml Outdated Show resolved Hide resolved
cloud_chatops/compose.yaml Outdated Show resolved Hide resolved
@@ -1,5 +1,5 @@
[pytest]
pythonpath = lib
pythonpath = src
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be simply . or blank? Since we're now missing the lib folder
I would have thought the from src import X in src/__init__.py does this for us?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what you mean here. pythonpath is used to add the dirs to the python search path for imports. Hence src makes sense here as its the root module of code.

Changed code to features being in a nested folder
Now the code can be run locally with the arg "local". If the arg is given then the path to secrets is changed. This way you don't need to build an image and container to test the code
Add the working directory to path for pylint
Updated the OS to include Ubuntu 22.
@khalford khalford merged commit bbb9d96 into master Sep 24, 2024
10 checks passed
@khalford khalford deleted the cloud_chatops_docker_secrets branch September 24, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants