-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud chatops docker secrets #172
Conversation
Added a docker file to deploy in container. Also, a CD workflow to build and push the container image to harbor
Docker deployment
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
===========================================
- Coverage 96.82% 76.47% -20.36%
===========================================
Files 69 3 -66
Lines 3120 85 -3035
===========================================
- Hits 3021 65 -2956
+ Misses 99 20 -79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -1,5 +1,5 @@ | |||
[pytest] | |||
pythonpath = lib | |||
pythonpath = src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be simply .
or blank? Since we're now missing the lib folder
I would have thought the from src import X
in src/__init__.py
does this for us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what you mean here. pythonpath is used to add the dirs to the python search path for imports. Hence src makes sense here as its the root module of code.
Changed code to features being in a nested folder
Now the code can be run locally with the arg "local". If the arg is given then the path to secrets is changed. This way you don't need to build an image and container to test the code
Add the working directory to path for pylint
Updated the OS to include Ubuntu 22.
Created a docker deployment for Cloud Chatops. Uses GitHub Actions as CD to build and push dev/prod images. Uses watchtower to keep the Cloud Chatops container up to date.
Unit tests and code "de-duplication" to be done/fixed in future PRs