ENH: Add monitoring script to collect information about VMs in different states #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a script for collecting the status of VMs and unit tests. One unit test is still being developed.
meoflynn
changed the title
Update the main method for collecting stats and add a test for checking an error is raised if a param is missing.
Add limit=10000 param to server queries to search across all projects and to get all servers that match query to be returned
Corrected package import and added missing docstring
anish-mudaraddi
requested changes
Feb 9, 2024
|
Also you'll want to move your test file into the tests folder |
khalford
requested changes
Feb 9, 2024
Updated the script based on the changes requested. Includes having a separate method to read the length of the generator object returned by the openstack query and some updates to formatting and unit tests
Add main method so the script can be run to collect data for an influxDB instance
queries were failing on prod because we were asking for too many servers with one call. Implemented a helper function to handle pagination for us
move tests to test folder and convert them to pytest tests add test for main and get_all_server_statuses
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 97.93% 98.45% +0.51%
==========================================
Files 50 12 -38
Lines 1844 842 -1002
==========================================
- Hits 1806 829 -977
+ Misses 38 13 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
fixed a bug and added fixed tests These scripts are now working with prod I'm not going for full test coverage for |
anish-mudaraddi
changed the title
khalford
requested changes
Feb 19, 2024
add return type and docstring to run_server_query
khalford
approved these changes
Feb 19, 2024
anish-mudaraddi
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new script for collecting information about VMs in different states with unit tests