Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2641 incorrect module names in psydata #2646

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Jul 4, 2024

Fixes #2641.

@hiker hiker temporarily deployed to integration July 4, 2024 08:06 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (ae4bc50) to head (2e337f0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2646   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         352      352           
  Lines       48463    48470    +7     
=======================================
+ Hits        48398    48405    +7     
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Joerg. Thanks for tracking this down.
You'll need to update the tutorials too - at least tutorial/practicals/nemo/2_nemo_profiling needs tweaking.
Does the User/Dev Guide have examples that need updating too?

examples/gocean/eg5/profile/test.x90 Outdated Show resolved Hide resolved
src/psyclone/psyir/nodes/psy_data_node.py Outdated Show resolved Hide resolved
@hiker
Copy link
Collaborator Author

hiker commented Jul 9, 2024

Looks good Joerg. Thanks for tracking this down. You'll need to update the tutorials too - at least tutorial/practicals/nemo/2_nemo_profiling needs tweaking.

Done, indeed I missed the example in the Fortran file (maybe I should just have removed that :) ).

Does the User/Dev Guide have examples that need updating too?

Yes, it did - a bit strange, I was certain I had updated that section, but maybe I am mixing things up. I've updated the user guide, added examples for names used in transformation, and shortened the example for DSL naming (and properly indented them).

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes have been made, thanks. (I too got a sense of deja vu when looking at the UG changes but I think that's because your last PR also changed things there?)
Updated UG builds fine and looks good.
Will proceed to merge.

@arporter arporter merged commit eeda0d0 into master Jul 9, 2024
12 checks passed
@arporter arporter deleted the 2641_incorrect_module_names_in_psydata branch July 9, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect module and region names
2 participants