-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2641 incorrect module names in psydata #2646
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2646 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 352 352
Lines 48463 48470 +7
=======================================
+ Hits 48398 48405 +7
Misses 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Joerg. Thanks for tracking this down.
You'll need to update the tutorials too - at least tutorial/practicals/nemo/2_nemo_profiling
needs tweaking.
Does the User/Dev Guide have examples that need updating too?
Done, indeed I missed the example in the Fortran file (maybe I should just have removed that :) ).
Yes, it did - a bit strange, I was certain I had updated that section, but maybe I am mixing things up. I've updated the user guide, added examples for names used in transformation, and shortened the example for DSL naming (and properly indented them). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requested changes have been made, thanks. (I too got a sense of deja vu when looking at the UG changes but I think that's because your last PR also changed things there?)
Updated UG builds fine and looks good.
Will proceed to merge.
Fixes #2641.