Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .gitignore rules for generated example code (for #2479) #2480

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Update .gitignore rules for generated example code (for #2479) #2480

merged 5 commits into from
Jan 23, 2024

Conversation

TeranIvy
Copy link
Collaborator

No description provided.

@TeranIvy TeranIvy added bug LFRic Issue relates to the LFRic domain Release Planning and creating PSyclone releases labels Jan 15, 2024
@TeranIvy TeranIvy self-assigned this Jan 15, 2024
@TeranIvy TeranIvy linked an issue Jan 15, 2024 that may be closed by this pull request
Generated example code is not ignored #2479
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c511ffb) 99.85% compared to head (74e8b7c) 99.85%.
Report is 1 commits behind head on master.

❗ Current head 74e8b7c differs from pull request most recent head f5a5ea5. Consider uploading reports for the commit f5a5ea5 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2480   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         352      352           
  Lines       47314    47314           
=======================================
  Hits        47245    47245           
  Misses         69       69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arporter
arporter requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Iva. I think one of the new files could just have a *.f90 in it - would you mind checking whether that works OK?
Apart from that, it's all fine.

examples/psyad/lfric/adjoint_partial/.gitignore Outdated Show resolved Hide resolved
arporter
arporter approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now! Thanks Iva. Will proceed to merge.

@arporter arporter merged commit 747fe4e into master Jan 23, 2024
9 checks passed
@arporter arporter deleted the gitignore_psyad_lfric branch January 23, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arporter arporter arporter approved these changes

@sergisiso sergisiso Awaiting requested review from sergisiso

@hiker hiker Awaiting requested review from hiker

Assignees

@TeranIvy TeranIvy

Labels
bug LFRic Issue relates to the LFRic domain ready to be merged Release Planning and creating PSyclone releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated example code is not ignored
2 participants
@TeranIvy @arporter