generator.py exception message bug fix (closes #2390) #2391
+25
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2391 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 349 349
Lines 47206 47207 +1
=======================================
+ Hits 47138 47139 +1
Misses 68 68
☔ View full report in Codecov by Sentry. |
|
Ready for first review from anyone who wants it. It's a very small change. So could be @arporter, @sergisiso @TeranIvy or @hiker |
arporter
reviewed
Nov 10, 2023
arporter
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generator.pyraises an exception when trying to construct a message that will be used to raise an exception. The reason for this is that there is an assumption that the result of applying .scope to a node will provide a node with a name (in particular aRoutine). However, the node returned could be aSchedulenode which has no name. This PR fixes this bug by finding the ancestorRoutinenode which is what is wanted (the name of the enclosing subroutine).