From 9e75ce6232421eb210ac35ad90d0b36ff68fd0d6 Mon Sep 17 00:00:00 2001 From: LonelyCat124 <3043914+LonelyCat124@users.noreply.github.com.> Date: Tue, 28 Jan 2025 14:59:26 +0000 Subject: [PATCH] flake issues --- src/psyclone/psyir/tools/definition_use_chains.py | 8 ++++---- .../definition_use_chains_backward_dependence_test.py | 1 + .../definition_use_chains_forward_dependence_test.py | 1 + 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/psyclone/psyir/tools/definition_use_chains.py b/src/psyclone/psyir/tools/definition_use_chains.py index ac2ba13c9e..c480b625cf 100644 --- a/src/psyclone/psyir/tools/definition_use_chains.py +++ b/src/psyclone/psyir/tools/definition_use_chains.py @@ -253,7 +253,7 @@ def find_forward_accesses(self): # If we have a basic block with no children then skip it, # e.g. for an if block with no code before the else # statement, as is found in NEMO4. - if(len(body) > 0): + if len(body) > 0: # We make a copy of the reference to have a detached # node to avoid handling the special cases based on # the parents of the reference. @@ -307,7 +307,7 @@ def find_forward_accesses(self): # If we have a basic block with no children then skip it, # e.g. for an if block with no code before the else # statement, as is found in NEMO4. - if(len(block) == 0): + if len(block) == 0: continue chain = DefinitionUseChain( self._reference, @@ -847,7 +847,7 @@ def find_backward_accesses(self): # If we have a basic block with no children then skip it, # e.g. for an if block with no code before the else # statement, as is found in NEMO4. - if(len(block) == 0): + if len(block) == 0: continue chain = DefinitionUseChain( self._reference, @@ -891,7 +891,7 @@ def find_backward_accesses(self): # If we have a basic block with no children then skip it, # e.g. for an if block with no code before the else # statement, as is found in NEMO4. - if(len(body) > 0): + if len(body) > 0: chain = DefinitionUseChain( self._reference.copy(), body, diff --git a/src/psyclone/tests/psyir/tools/definition_use_chains_backward_dependence_test.py b/src/psyclone/tests/psyir/tools/definition_use_chains_backward_dependence_test.py index a2e10c42f8..85fa66499a 100644 --- a/src/psyclone/tests/psyir/tools/definition_use_chains_backward_dependence_test.py +++ b/src/psyclone/tests/psyir/tools/definition_use_chains_backward_dependence_test.py @@ -688,6 +688,7 @@ def test_definition_use_chains_backward_accesses_nonassign_reference_in_loop( assert reaches[1] is routine.children[1].loop_body.children[0].lhs assert reaches[2] is routine.children[0].lhs + def test_definition_use_chains_backward_accesses_empty_schedules( fortran_reader, ): diff --git a/src/psyclone/tests/psyir/tools/definition_use_chains_forward_dependence_test.py b/src/psyclone/tests/psyir/tools/definition_use_chains_forward_dependence_test.py index 05ce1f1201..bb122de94a 100644 --- a/src/psyclone/tests/psyir/tools/definition_use_chains_forward_dependence_test.py +++ b/src/psyclone/tests/psyir/tools/definition_use_chains_forward_dependence_test.py @@ -938,6 +938,7 @@ def test_definition_use_chains_forward_accesses_multiple_routines( reaches = chains.find_forward_accesses() assert len(reaches) == 0 + def test_definition_use_chains_forward_accesses_empty_schedules( fortran_reader, ):