fix: 🩹 don't filter to two first observations in include_hba1c()
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These need to go through an exclude function before we slice it.
`as_duckplyr_tibble()` is deprecated.
Without `dplyr::compute()`, `actual` is a query and not a table. This is also why `colnames()` didn't work in the same test.
lwjohnst86
reviewed
Mar 12, 2025
man/include_gld_purchases.Rd
Outdated
lwjohnst86
reviewed
Mar 12, 2025
lwjohnst86
approved these changes
Mar 12, 2025
lwjohnst86
deleted the
fix/dont-filter-to-two-first-obs-in-include_hba1c
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don’t want to filter to only include the two first observations yet, since they need to go through an
exclude_function first.I also did some minor changes to the tests (updated to use
as_duckdb_tibble()and addeddplyr::compute())Closes #139
Closes #143 (duplicate issues)