Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix CRAN checks #127

Merged
merged 23 commits into from
Aug 15, 2024
Merged

build: fix CRAN checks #127

merged 23 commits into from
Aug 15, 2024

Conversation

lwjohnst86
Copy link
Member

Using Ctrl-Shift-E locally allows you to run CRAN checks to make sure it fits the requirements of CRAN, which will also hopefully fix the GitHub action build issues.

I touched on a lot of files to fix all the CRAN checks. When running the check, it will tell you exactly what the issues are.

I also found out that the include HbA1c had some issues when I ran the tests, so I fixed the code plus added more test cases.

This stacks on top of #122

lwjohnst86 added 23 commits June 19, 2024 16:10
@lwjohnst86
Merged origin/main into chore/fix-build-issues
57fd19b
@lwjohnst86
refactor: quiet the reading message
c135735
@lwjohnst86
chore: ignore these files in the build process
24ebe26
@lwjohnst86
refactor: these functions should only output data
69b8bc7
@lwjohnst86
build: update the targets pipeline to properly save sysdata
e7e8201
@lwjohnst86
chore: regenerate pipeline outputs
3216b9c
@lwjohnst86
test: confirm that only the last two dates are selected
d6fa1b2
@lwjohnst86
test: include some missing values
eb7446d
@lwjohnst86
test: this was incorrect, need to remove a column to test it correctly
2d20798
@lwjohnst86
test: import from dplyr to be explicit
e5ac7d2
@lwjohnst86
test: update the tests to correctly compare with other data object types
155154c
@lwjohnst86
refactor: take a dataframe rather than a string name of the register
61cd93e
@lwjohnst86
docs: remove periods from headers
85c393b
@lwjohnst86
docs: internal function examples can't be run during checks
9a9c475
@lwjohnst86
fix: the logic criteria wasn't being correctly loaded, need to conver…
d3f0d76 
…t to expression
@lwjohnst86
docs: this object needs to be documented
16ea193
@lwjohnst86
docs: typo in package title of DESCRIPTION
855722b
@lwjohnst86
build: move the needed packages for tests into Suggests
cab4afe 
...was giving issues during testing
@lwjohnst86
chore: regenerate the roxygen docs
11704ce
@lwjohnst86
docs: fix code after change to function
3aa7095
@lwjohnst86
chore: update wordlist using spelling::update_wordlist()
c75c160
@lwjohnst86
docs: need to include the version number in NEWS
01692d7
@lwjohnst86
docs: update dependency install instructions
c000e16
@lwjohnst86 lwjohnst86 self-assigned this Jun 25, 2024
Aastedet
Aastedet approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@Aastedet Aastedet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only comment I have is that it made a note for me that the "spelling" package was suggested, but not available for checking (I didn't have it installed, but after installing it and re-running checks I got 0 errors/warnings/notes).

@lwjohnst86 lwjohnst86 mentioned this pull request Jun 25, 2024
Merged
@lwjohnst86 lwjohnst86 merged commit c8a737b into build/add-targets-pipeline Aug 15, 2024
1 check passed
@lwjohnst86 lwjohnst86 deleted the chore/fix-build-issues branch August 15, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aastedet Aastedet Aastedet approved these changes

@signekb signekb Awaiting requested review from signekb

Assignees

@lwjohnst86 lwjohnst86

Labels
None yet
Projects
osdc development planning board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwjohnst86 @Aastedet