Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include_hba1c() to not slice by date #143

Closed
lwjohnst86 opened this issue Sep 19, 2024 · 1 comment · Fixed by #202
Closed

Fix include_hba1c() to not slice by date #143

lwjohnst86 opened this issue Sep 19, 2024 · 1 comment · Fixed by #202
Assignees
@signekb

Comments

@lwjohnst86
Copy link
Member

This happens afterwards, as written in a comment by @Aastedet in #138
@lwjohnst86 lwjohnst86 converted this from a draft issue Sep 19, 2024
@signekb
Copy link
Contributor

signekb commented Sep 19, 2024

@lwjohnst86 Is this a duplicate issue #139 ?

@signekb signekb mentioned this issue Mar 12, 2025
Merged
@signekb signekb moved this from Todo to In Progress in osdc development planning board Mar 12, 2025
lwjohnst86 added a commit that referenced this issue Mar 12, 2025
@signekb @lwjohnst86
fix: 🩹 don't filter to two first observations in include_hba1c() (#202
d581562 
)

## Description

We don’t want to filter to only include the two first observations yet,
since they need to go through an `exclude_` function first.

I also did some minor changes to the tests (updated to use
`as_duckdb_tibble()` and added `dplyr::compute()`)

Closes #139 #143 (duplicate issues)

---------

Co-authored-by: signekb <signekb@users.noreply.github.com>
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
@signekb signekb moved this from In Progress to Done in osdc development planning board Mar 12, 2025
@signekb signekb closed this as completed by moving to Done in osdc development planning board Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@signekb signekb

Labels
None yet
Projects
osdc development planning board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🩹 don't filter to two first observations in include_hba1c() steno-aarhus/osdc
2 participants
@lwjohnst86 @signekb