Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle imports that don’t begin with a “~” correctly #596

Merged

Conversation

alexandertrefz
Copy link
Contributor

@alexandertrefz alexandertrefz commented Mar 6, 2025

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix

What is the current behavior?

@forward or @use-ing 2 files from the same file creates a Type Error.

What is the new behavior?

The file compiles correctly.

Does this introduce a breaking change?

  • No

@alexandertrefz alexandertrefz requested a review from a team as a code owner March 6, 2025 23:29
@alexandertrefz alexandertrefz mentioned this pull request Mar 6, 2025
5 tasks
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@christian-bromann christian-bromann merged commit e357bc1 into stenciljs:main Mar 7, 2025
4 checks passed
@christian-bromann
Copy link
Member

I think it would make sense to get some tests in place here but happy to have this as a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants