Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gating #25

Merged
merged 2 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: tidygate
Type: Package
Title: Add Gate Information to Your Tibble
Version: 0.5.2
Version: 0.5.3
Authors@R:
c(person(given = "Stefano",
family = "Mangiola",
Expand Down
3 changes: 2 additions & 1 deletion R/functions_OLD.R
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,8 @@ gate_programmatic <-
.dim1,
.dim2,
gate_list,
name = "gate") {
name = "gate",
...) {

# Comply with CRAN NOTES
. = NULL
Expand Down
4 changes: 2 additions & 2 deletions R/functions_chr_int.R
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,6 @@ pretty_plot_chr_int = function(.data,
#' @param .size A column symbol. Size of points
#' @param opacity A number between 0 and 1. The opacity level of the data points
#' @param how_many_gates An integer. The number of gates to label
#' @param gate_list A list of gates. It is returned by gate function as attribute \"gate\". If you want to create this list yourself, each element of the list is a data frame with x and y columns. Each row is a coordinate. The order matter.
#' @param ... Further parameters passed to the function gatepoints::fhs
#'
#' @return A tibble with additional columns
Expand Down Expand Up @@ -379,7 +378,8 @@ gate_programmatic_chr_int <-
function(.data,
.dim1,
.dim2,
gate_list
gate_list,
...
) {
# Comply with CRAN NOTES
. = NULL
Expand Down
6 changes: 6 additions & 0 deletions R/gate_app.R
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ server <-

output$plot <- plotly::renderPlotly({

# Fix CRAN NOTES
.key <- NULL
.selected <- NULL
dimension_x <- NULL
dimension_y <- NULL

# Begin recording selection and brush information
select_data <- plotly::event_data("plotly_selected")
brush_data <- plotly::event_data("plotly_brushed")
Expand Down
3 changes: 3 additions & 0 deletions R/methods.R
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,9 @@ gate_custom <-

message("tidygate says: this feature is in early development and may undergo changes or contain bugs.")

# Fix CRAN NOTES
key <- NULL

# Create tibble with .key column
data <-
custom_plot |>
Expand Down
1 change: 0 additions & 1 deletion man/figures/lifecycle-archived.svg

This file was deleted.

1 change: 0 additions & 1 deletion man/figures/lifecycle-defunct.svg

This file was deleted.

1 change: 0 additions & 1 deletion man/figures/lifecycle-deprecated.svg

This file was deleted.

1 change: 0 additions & 1 deletion man/figures/lifecycle-experimental.svg

This file was deleted.

1 change: 0 additions & 1 deletion man/figures/lifecycle-maturing.svg

This file was deleted.

1 change: 0 additions & 1 deletion man/figures/lifecycle-questioning.svg

This file was deleted.

1 change: 0 additions & 1 deletion man/figures/lifecycle-soft-deprecated.svg

This file was deleted.

1 change: 0 additions & 1 deletion man/figures/lifecycle-stable.svg

This file was deleted.

1 change: 0 additions & 1 deletion man/figures/lifecycle-superseded.svg

This file was deleted.

Empty file modified man/gate-methods.Rd
100755 → 100644
Empty file.
2 changes: 0 additions & 2 deletions man/gate_interactive_chr_int.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/gate_programmatic.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/gate_programmatic_chr_int.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading