-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect order of parameters when calling PostGIS functions #1305
Merged
bobeal
merged 2 commits into
develop
from
fix/incorrect-parameter-order-geoqueries-parameters
Jan 6, 2025
Merged
fix: incorrect order of parameters when calling PostGIS functions #1305
bobeal
merged 2 commits into
develop
from
fix/incorrect-parameter-order-geoqueries-parameters
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 69 files ±0 69 suites ±0 1m 26s ⏱️ +7s Results for commit 4c50dea. ± Comparison against base commit e535bee. This pull request removes 199 and adds 44 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Quality Gate passedIssues Measures |
JDFleury
approved these changes
Jan 6, 2025
junjou
approved these changes
Jan 6, 2025
thomasBousselin
approved these changes
Jan 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a NGSI-LD Geoquery (4.10):
location
by default)Then the semantic of the geospatial relationship is for instance:
within, as specified by [14], the reference geometry.
However, in Stellio, we were currently implementing such a query with:
Which says: Returns TRUE if geometry A is within geometry B (https://postgis.net/docs/ST_Within.html). Which is the opposite of what the specification says and is thus being fixed in this PR.
It should only have impact on geoqueries using
contains
andwithin
.