Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the idna dep (and url, hickory-proto) #1788

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Dec 11, 2024

What

Update the idna dep, and update transitive deps accordingly, as well as the url and hickory-proto deps to be able to use the newer idna.

Why

The idna crate that the url and hickory-proto crate depend on has a rust security alert seen in the cargo-deny runs:

Commands run for anyone wishing to verify / replicate:

$ cargo update -p url
$ cargo update -p hickory-proto

@leighmcculloch leighmcculloch marked this pull request as ready for review December 11, 2024 08:48
@leighmcculloch leighmcculloch enabled auto-merge (squash) December 11, 2024 08:48
@leighmcculloch leighmcculloch changed the title update the url dep from 2.5.2 to 2.5.4 update the idna dep (and url, hickory-proto) Dec 11, 2024
@leighmcculloch
Copy link
Member Author

leighmcculloch commented Dec 11, 2024

Pending question with legal regarding the Unicode-3.0 license error:

@leighmcculloch
Copy link
Member Author

leighmcculloch commented Jan 17, 2025

Unicode 3.0 was approved, but this PR is dependent on embedding the licenses in the software, i.e.:

@leighmcculloch leighmcculloch merged commit 39cf6a0 into main Jan 17, 2025
24 of 25 checks passed
@leighmcculloch leighmcculloch deleted the update-url branch January 17, 2025 23:05
@leighmcculloch
Copy link
Member Author

Oops, I had meant to merge this after #1837. We need to make sure we don't release the stellar-cli with this change until #1837 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants