-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soroban network start
followup improvements
#1230
Comments
I think
While these things both involve networks, they're otherwise unrelated bundles of operations. For example, take the following help output. It is easy to think that
I think the relationship between the subcommands is much clearer if separated:
|
Suggested follow up:
Edit: moved to own issue here: |
soroban network start
followup improvements
Add stellar network container logs command in the terminal and can close |
The
soroban network start
andsoroban network stop
commands were added in PR # 1107, and as part of the PR discussion there were some follow up things that we wanted to improve on:Todo
network container logs
exists is enoughdocker_host
flagsoroban network start
make sense? Or should this eventually move to this tosoroban instance start | stop
orsoroban network instance start | stop
? See feat: start network docker container with cli #1107 (comment) for more info -> this was changed to soroban network container startstop
command)On the chopping block:
stellar network container logs
to see the rest of the logs. Is this good, or do we think that a health check is important?The text was updated successfully, but these errors were encountered: