Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for images in sitemap #64

Open
3 of 7 tasks
stefandoorn opened this issue Jan 22, 2019 · 7 comments
Open
3 of 7 tasks

Add support for images in sitemap #64

stefandoorn opened this issue Jan 22, 2019 · 7 comments
Milestone
v2.0

Comments

@stefandoorn
Copy link
Owner

stefandoorn commented Jan 22, 2019 •
edited
Loading

#51 & #61

  • Make sure paths are browser URL's (cache)
  • Proper DI in ProductToImageSitemapArrayConverter
  • Make image support optional (default = on)
  • Support localisation (optional)
  • Support product provider
  • Support taxon provider
  • Add specs for ProductImagesToSitemapImagesCollectionGenerator
@stefandoorn stefandoorn added this to the v2.0 milestone Jan 22, 2019
@stefandoorn stefandoorn mentioned this issue Jan 22, 2019
Merged
2 tasks
@stefandoorn stefandoorn modified the milestones: v2.0, v1.0, v1.1 Jan 23, 2019
@stefandoorn
Copy link
Owner Author

@Roshyo Would you be able to help on moving this issue further to completeness?

@Roshyo
Copy link
Contributor

Roshyo commented Jul 8, 2019

Hi, I'll try to find some time to do so.

@Roshyo Roshyo mentioned this issue Aug 1, 2019
Closed
@Roshyo
Copy link
Contributor

Roshyo commented Aug 1, 2019

@stefandoorn what do you mean by Support taxon provider ?

@stefandoorn
Copy link
Owner Author

To have the taxon provider also inject it's images, currently only the product provider is having that supported.

@Roshyo
Copy link
Contributor

Roshyo commented Aug 7, 2019

Oh okay. I'll do another PR for this if you're okay.

Maybe you want to review this one ?

It fixes Make image support optional (default = on) and Add specs for ProductImagesToSitemapImagesCollectionGenerator

@Roshyo
Copy link
Contributor

Roshyo commented Aug 13, 2019

Support taxon provider also done

@Roshyo
Copy link
Contributor

Roshyo commented Aug 15, 2019

@stefandoorn can you have a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@stefandoorn @Roshyo