-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mustache workaround only taking top level keys into account #84
Open
peters-david
wants to merge
7
commits into
main
Choose a base branch
from
83-mustache-workaround-causes-ids-to-miss
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe restructure the new fuction for better readability? def insert_into_dict(d: dict, parts: list) -> None:
"""Inserts nested keys and value into a dictionary."""
*keys, last_key, value = parts
for key in keys:
d = d.setdefault(key, {})
d[last_key] = value |
same for the original "fill_template" function. I don't want to criticize your programming but its very hard to read. maybe something like, just as a possibility import re
import chevron
async def fill_template(client, path: str, logger) -> str:
"""Reads a template file, replaces placeholders with fetched IDs, and returns the updated content."""
with open(path, 'r') as file:
config = file.read()
placeholders = re.findall(r'{{\s*(?:project|registry):[\w.\-_]+\s*}}', config)
logger.info("Found id templates", extra={"placeholders": placeholders})
replacements = {}
for placeholder in (p.strip(" {}") for p in placeholders):
placeholder_type, placeholder_value = placeholder.split(':')
replacement_value = await fetch_id(client, placeholder_type, placeholder_value)
# Create nested dictionary structure for replacements
insert_into_dict(replacements, placeholder.split('.') + [str(replacement_value)])
return chevron.render(config, replacements) |
and maybe we could include the change from nuitka to pyinstaller in this. its a very small change that safes a lot of pipeline runtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken ids when project or registry names start with the same text.