Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non json logging #70

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Non json logging #70

merged 5 commits into from
Jan 9, 2025

Conversation

peters-david
Copy link
Contributor

Add non-json logging to the new logging style.

@peters-david
Copy link
Contributor Author

ImportError: cannot import name 'VerifyTypes' from 'httpx._types' was mentioned in harborapi.

@peters-david
Copy link
Contributor Author

Pinned the httpx version as temporal fix for a problem in harborapi.

@peters-david peters-david requested a review from a team December 18, 2024 10:25
@peters-david peters-david marked this pull request as ready for review December 18, 2024 10:26
sf-agr
sf-agr approved these changes Jan 9, 2025
View reviewed changes
Copy link

@sf-agr sf-agr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@peters-david peters-david merged commit e67bea6 into main Jan 9, 2025
2 checks passed
@peters-david peters-david deleted the non-json-logging branch January 9, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sf-agr sf-agr sf-agr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peters-david @sf-agr