Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust send model height depending on contents #17336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cuteivist
Copy link
Contributor

@Cuteivist Cuteivist commented Feb 19, 2025

Closes #17310

What does the PR do

  • Recipient selector panel implicitHeight will always be only needed height for component
  • Added visualHeight property to recipient selector so that it always uses constant height for each tab. It is separate because in case tab is empty but other tabs have scrollable content we don't want to have scrollable empty tab. For that purpose the additional overlay is used in Send modal to "extend" visuall the recipient view
  • The Send modal height is adjusted to the content with constrains of window height with margins.
  • The send modal height is now animated to get better experience and prevent jumping.
  • Added minimum modal height to not create "squashed" state
  • Fixed missing radiuses on modal rectangle, caused by blur effects not being rounded
  • Fixed dropshadow for header and footer

Affected areas

Simple send modal

Architecture compliance

Screenshot of functionality (including design for comparison)

send_modal_2.mov

@status-im-auto
Copy link
Member

status-im-auto commented Feb 19, 2025

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d7aca8a #1 2025-02-19 13:34:02 ~7 min macos/aarch64 🍎dmg
✔️ d7aca8a #1 2025-02-19 13:37:01 ~10 min tests/nim 📄log
✔️ d7aca8a #1 2025-02-19 13:40:13 ~13 min tests/ui 📄log
✔️ d7aca8a #1 2025-02-19 13:46:07 ~19 min macos/x86_64 🍎dmg
✔️ d7aca8a #1 2025-02-19 13:49:03 ~22 min linux-nix/x86_64 📦tgz
✔️ d7aca8a #1 2025-02-19 13:49:47 ~22 min linux/x86_64 📦tgz
✔️ d7aca8a #1 2025-02-19 13:55:32 ~28 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5be0624 #2 2025-02-20 06:09:11 ~5 min macos/aarch64 🍎dmg
✔️ 5be0624 #2 2025-02-20 06:14:14 ~10 min tests/nim 📄log
✔️ 5be0624 #2 2025-02-20 06:17:14 ~13 min macos/x86_64 🍎dmg
✔️ 5be0624 #2 2025-02-20 06:17:21 ~13 min tests/ui 📄log
✔️ 5be0624 #2 2025-02-20 06:26:34 ~22 min linux-nix/x86_64 📦tgz
✔️ 5be0624 #2 2025-02-20 06:26:52 ~23 min linux/x86_64 📦tgz
✔️ 5be0624 #2 2025-02-20 06:32:20 ~28 min windows/x86_64 💿exe
✔️ f4473f3 #3 2025-02-20 22:36:31 ~5 min macos/aarch64 🍎dmg
✔️ f4473f3 #3 2025-02-20 22:39:55 ~8 min tests/nim 📄log
✔️ f4473f3 #3 2025-02-20 22:44:29 ~13 min macos/x86_64 🍎dmg
✔️ f4473f3 #3 2025-02-20 22:45:04 ~13 min tests/ui 📄log
✔️ f4473f3 #3 2025-02-20 22:52:45 ~21 min linux-nix/x86_64 📦tgz
✔️ f4473f3 #3 2025-02-20 22:53:18 ~22 min linux/x86_64 📦tgz
✔️ f4473f3 #3 2025-02-20 22:59:28 ~28 min windows/x86_64 💿exe

@Cuteivist Cuteivist marked this pull request as draft February 20, 2025 05:45
@Cuteivist Cuteivist force-pushed the feat/send-modal-recipient-view-height-17310 branch from d7aca8a to 5be0624 Compare February 20, 2025 06:03
@Cuteivist Cuteivist marked this pull request as ready for review February 20, 2025 07:23
@Cuteivist Cuteivist marked this pull request as draft February 20, 2025 07:23
@Cuteivist Cuteivist force-pushed the feat/send-modal-recipient-view-height-17310 branch from 5be0624 to f4473f3 Compare February 20, 2025 22:30
@Cuteivist Cuteivist marked this pull request as ready for review February 21, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipient height should be as big as longest content of any recipient tab
2 participants