Skip to content

Commit

Permalink
Merge pull request #150 from statsig-io/increase-max-user-obj-limit
Browse files Browse the repository at this point in the history
increase max user object limit
  • Loading branch information
jkw-statsig authored Apr 20, 2022
2 parents 48c1549 + a524ac6 commit 33cf19b
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "statsig-node",
"version": "4.14.0",
"version": "4.15.0",
"description": "Statsig Node.js SDK for usage in multi-user server environments.",
"main": "dist/src/index.js",
"scripts": {
Expand Down
10 changes: 5 additions & 5 deletions src/__tests__/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ describe('Verify behavior of top level index functions', () => {
let configName = 'config_downloaded';

const spy = jest.spyOn(statsig._logger, 'log');
for (let ii = 0 ; ii < 10000; ii++) {
for (let ii = 0; ii < 10000; ii++) {
await statsig.getConfig(user, configName);
}

Expand All @@ -461,7 +461,7 @@ describe('Verify behavior of top level index functions', () => {
let configName = 'config_downloaded';

const spy = jest.spyOn(statsig._logger, 'log');
for (let ii = 0 ; ii < 10000; ii++) {
for (let ii = 0; ii < 10000; ii++) {
user.userID = ii;
await statsig.getConfig(user, configName);
}
Expand All @@ -480,7 +480,7 @@ describe('Verify behavior of top level index functions', () => {
let configName = 'config_downloaded';

const spy = jest.spyOn(statsig._logger, 'log');
for (let ii = 0 ; ii < 10000; ii++) {
for (let ii = 0; ii < 10000; ii++) {
jest.spyOn(Evaluator, 'getConfig').mockImplementation((_, configName) => {
return new ConfigEvaluation(true, 'rule_id_config_' + ii, [], {
string: '12345',
Expand Down Expand Up @@ -606,10 +606,10 @@ describe('Verify behavior of top level index functions', () => {
expect.assertions(2);
let str_1k = str_64;
// create a 1k long string
for (let i = 0; i < 4; i++) {
for (let i = 0; i < 5; i++) {
str_1k += str_1k;
}
expect(str_1k.length).toBe(1024);
expect(str_1k.length).toBe(2048);
return statsig.initialize(secretKey).then(() => {
let bigUser = {
userID: str_64 + 'more',
Expand Down
5 changes: 3 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const { Layer } = require('./Layer');

const MAX_VALUE_SIZE = 64;
const MAX_OBJ_SIZE = 1024;
const MAX_USER_SIZE = 2048;
let hasLoggedNoUserIdWarning = false;

/**
Expand Down Expand Up @@ -482,9 +483,9 @@ function trimUserObjIfNeeded(user) {
);
user.userID = user.userID.toString().substring(0, MAX_VALUE_SIZE);
}
if (shouldTrimParam(user, MAX_OBJ_SIZE)) {
if (shouldTrimParam(user, MAX_USER_SIZE)) {
user.custom = {};
if (shouldTrimParam(user, MAX_OBJ_SIZE)) {
if (shouldTrimParam(user, MAX_USER_SIZE)) {
console.warn(
'statsigSDK> User object is too large, only keeping the user ID.',
);
Expand Down

0 comments on commit 33cf19b

Please sign in to comment.