[AXON-293] Add _isServerEnv override for VSCODE extensions #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabella-dot
changed the title
marcomura
reviewed
Apr 28, 2025
| /** | ||
| * Overrides the blocking of exposure events if you are working in a Node js project | ||
| */ | ||
| overrideServerEnv?: boolean |
There was a problem hiding this comment.
I would rename it to forceLogExposures for clarity
marcomura
reviewed
Apr 28, 2025
| @@ -119,7 +119,8 @@ export class EventLogger { | |||
| } | |||
|
|
|||
| start(): void { | |||
| if (_isServerEnv()) { | |||
| const override = this._options?.overrideServerEnv | |||
| if (_isServerEnv() && !override) { | |||
There was a problem hiding this comment.
to improve performances, values should be checked before function calls
marcomura
reviewed
Apr 28, 2025
|
|
||
| const override = this._options?.overrideServerEnv; | ||
|
|
||
| if (_isServerEnv() && !override) { |
marcomura
reviewed
Apr 28, 2025
| function _assignGlobalInstance(sdkKey: string, client: StatsigClientInterface) { | ||
| if (_isServerEnv()) { | ||
| function _assignGlobalInstance(sdkKey: string, client: StatsigClientInterface, overrideServerEnv?: boolean) { | ||
| if (_isServerEnv() && !overrideServerEnv) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change:
_isServerEnv()method which blocks our ability to send exposure eventsWhy:
Related to #23