feat(papyrus_network): add broadcast and sqmr metrics structs

[AlonLStarkWare]

• refactor(papyrus_network): require network mamanger metrics when constructing nm
• refactor(papyrus_network): clean up metrics tracking
• feat(papyrus_network): add broadcast and sqmr metrics structs

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-02-09T19:26:20Z
• Started at 2025-02-09T19:32:31Z
• Started at 2025-02-10T09:46:59Z
• Started at 2025-02-10T12:01:27Z

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.881 ms 34.910 ms 34.942 ms]
change: [-1.4348% -1.2715% -1.1066%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
8 (8.00%) high mild
1 (1.00%) high severe

[ShahakShama]

Reviewed 4 of 5 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: 7 of 17 files reviewed, 6 unresolved discussions (waiting on @eitanm-starkware and @noamsp-starkware)

---

crates/starknet_consensus_manager/src/consensus_manager.rs line 64 at r4 (raw file):

        }

        // TODO(alonl): consider splitting the metrics by topic

Move this TODO to papyrus_network on top of the BroadcastNetworkMetrics struct definition

---

crates/papyrus_network/src/network_manager/network_manager_metrics.rs line 15 at r4 (raw file):

}

pub struct SqmrNetworkMetrics {}

As discussed be-al pe, move num_active_*_sessions to here.
This means you can remove those metrics from mempool p2p and consensus

---

crates/papyrus_network/src/network_manager/mod.rs line 526 at r4 (raw file):

        event: gossipsub_impl::ExternalEvent,
    ) -> Result<(), NetworkError> {
        if let Some(metrics) = self.metrics.as_ref() {

use and_then to squash these two if-let into one if-let

---

crates/papyrus_network/src/network_manager/mod.rs line 526 at r4 (raw file):

        event: gossipsub_impl::ExternalEvent,
    ) -> Result<(), NetworkError> {
        if let Some(metrics) = self.metrics.as_ref() {

Unrelated to the PR, could you add a trace level log that we received a broadcast message and display the topic?

---

crates/papyrus_network/src/network_manager/mod.rs line 604 at r4 (raw file):

    fn broadcast_message(&mut self, message: Bytes, topic_hash: TopicHash) {
        if let Some(metrics) = self.metrics.as_ref() {

Same here

---

crates/papyrus_network/src/network_manager/mod.rs line 604 at r4 (raw file):

    fn broadcast_message(&mut self, message: Bytes, topic_hash: TopicHash) {
        if let Some(metrics) = self.metrics.as_ref() {

Unrelated to the PR, could you add a trace level log that we're sending a broadcast message and display the topic?

[AlonLStarkWare]

Reviewable status: 0 of 18 files reviewed, 4 unresolved discussions (waiting on @eitanm-starkware, @noamsp-starkware, and @ShahakShama)

---

crates/papyrus_network/src/network_manager/mod.rs line 526 at r4 (raw file):

Previously, ShahakShama wrote…

Unrelated to the PR, could you add a trace level log that we received a broadcast message and display the topic?

Done

---

crates/papyrus_network/src/network_manager/mod.rs line 526 at r4 (raw file):

Previously, ShahakShama wrote…

use and_then to squash these two if-let into one if-let

Done.

---

crates/papyrus_network/src/network_manager/mod.rs line 604 at r4 (raw file):

Previously, ShahakShama wrote…

Same here

Done.

---

crates/papyrus_network/src/network_manager/mod.rs line 604 at r4 (raw file):

Previously, ShahakShama wrote…

Unrelated to the PR, could you add a trace level log that we're sending a broadcast message and display the topic?

Done

---

crates/starknet_consensus_manager/src/consensus_manager.rs line 64 at r4 (raw file):

Previously, ShahakShama wrote…

Move this TODO to papyrus_network on top of the BroadcastNetworkMetrics struct definition

Done.

---

crates/papyrus_network/src/network_manager/network_manager_metrics.rs line 15 at r4 (raw file):

Previously, ShahakShama wrote…

As discussed be-al pe, move num_active_*_sessions to here.
This means you can remove those metrics from mempool p2p and consensus

Done.

[ShahakShama]

Reviewed 11 of 13 files at r6, 7 of 7 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)

[ShahakShama]

Reviewed 11 of 11 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)