chore(starknet_integration_tests): move verify_tx_accepted to monitoring_utils

[nadin-Starkware]

Stack:

• feat(starknet_integration_tests): sequencer simulator binary #4032
• refactor(starknet_integration_tests): create load_and_validate_config function #4028
• refactor(starknet_integration_tests): remove node_setup arg from monitoring_utils functions #4027
• chore(starknet_integration_tests): move verify_tx_accepted to monitoring_utils #4026 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[lev-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

---

crates/starknet_integration_tests/src/sequencer_manager.rs line 317 at r1 (raw file):

        let account = self.tx_generator.account_with_id(sender_account);
        let expected_n_batched_txs = nonce_to_usize(account.get_nonce());
        verify_txs_accepted(monitoring_client, sequencer_idx, expected_n_batched_txs).await;

For me is really confusing to see that the function verify_txs_accepted is called from the function verify_txs_accepted. I would prefer monitoring_utils::verify_txs_accepted.

Code quote:

verify_txs_accepted

[nadin-Starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)

---

crates/starknet_integration_tests/src/sequencer_manager.rs line 317 at r1 (raw file):

Previously, lev-starkware wrote…

For me is really confusing to see that the function verify_txs_accepted is called from the function verify_txs_accepted. I would prefer monitoring_utils::verify_txs_accepted.

Done.

[lev-starkware]

Reviewable status: 0 of 2 files reviewed, all discussions resolved

[lev-starkware]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)