feat(papyrus_network): track broadcast metrics

starkware-libs · Feb 10, 2025 · 7f33203 · 7f33203
1 parent b187b68
commit 7f33203
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/crates/papyrus_network/src/network_manager/mod.rs b/crates/papyrus_network/src/network_manager/mod.rs
@@ -523,6 +523,11 @@ impl<SwarmT: SwarmTrait> GenericNetworkManager<SwarmT> {
         &mut self,
         event: gossipsub_impl::ExternalEvent,
     ) -> Result<(), NetworkError> {
+        if let Some(metrics) = self.metrics.as_ref() {
+            if let Some(broadcast_metrics) = metrics.broadcast_metrics.as_ref() {
+                broadcast_metrics.num_received_broadcast_messages.increment(1);
+            }
+        }
         let gossipsub_impl::ExternalEvent::Received { originated_peer_id, message, topic_hash } =
             event;
         let broadcasted_message_metadata = BroadcastedMessageMetadata {
@@ -596,6 +601,11 @@ impl<SwarmT: SwarmTrait> GenericNetworkManager<SwarmT> {
     }
 
     fn broadcast_message(&mut self, message: Bytes, topic_hash: TopicHash) {
+        if let Some(metrics) = self.metrics.as_ref() {
+            if let Some(broadcast_metrics) = metrics.broadcast_metrics.as_ref() {
+                broadcast_metrics.num_sent_broadcast_messages.increment(1);
+            }
+        }
         self.swarm.broadcast_message(message, topic_hash);
     }
 

diff --git a/crates/starknet_consensus_manager/src/consensus_manager.rs b/crates/starknet_consensus_manager/src/consensus_manager.rs
@@ -61,6 +61,7 @@ impl ConsensusManager {
             return std::future::pending().await;
         }
 
+        // TODO(alonl): consider splitting the metrics by topic
         let network_manager_metrics = Some(NetworkManagerMetrics {
             num_connected_peers: CONSENSUS_NUM_CONNECTED_PEERS,
             num_active_inbound_sessions: CONSENSUS_NUM_ACTIVE_INBOUND_SESSIONS,