Added some constfolding for array-pops. #7690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 21, 2025
|
This change is |
This was referenced Apr 21, 2025
orizi
force-pushed
the
spr/main/792add5c
branch
from
8abbdf9 to
bf66a0e
Compare
orizi
force-pushed
the
spr/main/7f3fce8a
branch
from
052e932 to
1ac754b
Compare
orizi
force-pushed
the
spr/main/7f3fce8a
branch
from
1ac754b to
dcf99e5
Compare
orizi
force-pushed
the
spr/main/792add5c
branch
from
bf66a0e to
fade034
Compare
orizi
force-pushed
the
spr/main/7f3fce8a
branch
from
dcf99e5 to
29bcce7
Compare
orizi
force-pushed
the
spr/main/792add5c
branch
from
fade034 to
ecfb59d
Compare
orizi
force-pushed
the
spr/main/7f3fce8a
branch
from
29bcce7 to
85506de
Compare
orizi
force-pushed
the
spr/main/792add5c
branch
from
2ea1832 to
e1aeb27
Compare
orizi
force-pushed
the
spr/main/7f3fce8a
branch
2 times, most recently
from
0896c18 to
d5d468d
Compare
orizi
force-pushed
the
spr/main/792add5c
branch
from
e1aeb27 to
71e985d
Compare
orizi
force-pushed
the
spr/main/7f3fce8a
branch
from
d5d468d to
6a4b21e
Compare
orizi
force-pushed
the
spr/main/792add5c
branch
2 times, most recently
from
231bf40 to
880cdb3
Compare
orizi
force-pushed
the
spr/main/7f3fce8a
branch
2 times, most recently
from
e3d67b3 to
bc108b2
Compare
orizi
force-pushed
the
spr/main/792add5c
branch
from
880cdb3 to
a5d2d6c
Compare
orizi
force-pushed
the
spr/main/7f3fce8a
branch
from
bc108b2 to
95e0d77
Compare
orizi
force-pushed
the
spr/main/7f3fce8a
branch
from
95e0d77 to
a3a877c
Compare
commit-id:7f3fce8a
orizi
force-pushed
the
spr/main/7f3fce8a
branch
from
a3a877c to
9f9c19f
Compare
gilbens-starkware
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 3 files reviewed, all discussions resolved
gilbens-starkware
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
Copyof vars in const-folding. #7701