-
Notifications
You must be signed in to change notification settings - Fork 602
Apply ReturnOptimization to the input of the match optimizer test. #7620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
looks like this test is broken :( Code quote:
|
it is applicable when we apply the return optimization Code quote:
|
45aa53d
to
42ba226
Compare
Previously, ilyalesokhin-starkware wrote…
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-lowering/src/optimizations/test_data/match_optimization
line 1656 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
it is applicable when we apply the return optimization
i don't understand.
a discussion (no related file):
is this preferable? note that it "hide" part of what the optimization actually did.
maybe add it as a boolean for the test params?
Previously, orizi wrote…
what does it hide? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)
a discussion (no related file):
Previously, ilyalesokhin-starkware wrote…
what does it hide?
the name and the block ids change further, and remappings are deleted.
Previously, orizi wrote…
in the input to the optimization, not in the result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion
a discussion (no related file):
Previously, ilyalesokhin-starkware wrote…
in the input to the optimization, not in the result.
oh - nm.
42ba226
to
326e10f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
No description provided.