Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bleve search index from old branch and wrap in feature flag #522

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Joshswooft
Copy link

As discussed on discord this pulls in changes from @delaneyj old branch: https://github.com/starfederation/datastar/compare/search

I've wrapped the current work in a feature flag so I can proceed with making the search UI at a later date.

@bencroker
Copy link
Collaborator

Thanks for this! Running locally, I see "Search feature enabled" but I’m not seeing any search UI. Is there anything I need to do, or just be more patient?

@Joshswooft
Copy link
Author

Thanks for this! Running locally, I see "Search feature enabled" but I’m not seeing any search UI. Is there anything I need to do, or just be more patient?

Hey @bencroker , I've just added some desktop styling. I'm hoping mobile can wait until I get some more free time although I don't know when that will be.

@delaneyj The search works but already I've noticed it would benefit if for instance the title field was 'boosted' compared to the rest of the other fields? Worth playing around with but again feel like this is more of an optimization that can come in the future :)

@bencroker
Copy link
Collaborator

Ok, thanks for your work on this thus far, and I look forward to playing with it some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants