Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitwuzla: Do not error when option incremental is set to false. #371

Merged
merged 1 commit into from
Feb 14, 2025
Merged

bitwuzla: Do not error when option incremental is set to false. #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bitwuzla/src/bitwuzla_solver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,9 @@ void BzlaSolver::set_opt(const std::string option, const std::string value)
{
if (option == "incremental")
{
if (value != "true")
{
throw NotImplementedException("Bitwuzla only supports incremental mode");
}
// Bitwuzla does not distinguish between incremental and non-incremental
// solving.
return;
}
else if (option == "time-limit")
{
Expand All @@ -118,7 +117,8 @@ void BzlaSolver::set_opt(const std::string option, const std::string value)
catch (const bitwuzla::Exception & exception)
{
std::string detail = exception.what();
// Remove "invalid call to 'bitwuzla::Options::set(...)'" from exception message.
// Remove "invalid call to 'bitwuzla::Options::set(...)'" from exception
// message.
detail.erase(0, detail.find(")"));
detail.erase(0, detail.find(","));
throw IncorrectUsageException("Bitwuzla backend got bad option " + option
Expand Down