Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding exception #665

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix encoding exception #665

merged 1 commit into from
Jan 21, 2025

Conversation

vikkkko
Copy link
Collaborator

@vikkkko vikkkko commented Jan 21, 2025

The wrong encoding used caused the indexer to fail to decode successfully.

@reinamora137 reinamora137 force-pushed the src101/fix_encodeData branch from e6f28ad to b5ce88d Compare January 21, 2025 13:45
@reinamora137
Copy link
Contributor

This implies SRC-101 is not using msgpack and zlib compression on the json strings?

@vikkkko
Copy link
Collaborator Author

vikkkko commented Jan 21, 2025

This implies SRC-101 is not using msgpack and zlib compression on the json strings?

This implies SRC-101 is not using msgpack and zlib compression on the json strings?

Let me confirm. I seem to have misunderstood something.

@vikkkko
Copy link
Collaborator Author

vikkkko commented Jan 21, 2025

This implies SRC-101 is not using msgpack and zlib compression on the json strings?

not used

@reinamora137 reinamora137 force-pushed the src101/fix_encodeData branch from b5ce88d to 84b3c9e Compare January 21, 2025 23:11
@reinamora137
Copy link
Contributor

reinamora137 commented Jan 21, 2025 •
edited
Loading

This implies SRC-101 is not using msgpack and zlib compression on the json strings?

not used

Wow, ok. That’s a major reduction in size and the default creation method on the frontend code.. probably why these transactions created from the API failed being parsed?

9623cc849ec1fd7bb7007e463c755e8bab57be57ff363aa21ded4bdc77959297

5640c527cf7a5f855167b0e4520f285a37daafda3992c34c18c7693bca0022a2

msgpack and zlib should be implemented for the Olga stamp modifications for sure

@reinamora137 reinamora137 merged commit cb8e578 into dev Jan 21, 2025
2 checks passed
@reinamora137 reinamora137 deleted the src101/fix_encodeData branch January 21, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikkkko @reinamora137