Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile menu disclosure a11y, add landmarks, add list structure, fix alt-text, prettier, eslint #1140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jason-me
Copy link
Contributor

Describe your changes

  • Added aria-expanded and aria-controls to mobile hamburger menu. Issue #1044
  • Added landmark regions (Banner, Main, Nav in footer, etc.) Issue #1045
  • Added list structure missing from nav content (header, footer, expanded mobile) Issue #1049
  • Fixed incorrect alt text for card images Issue #1048

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device

@jason-me
Copy link
Contributor Author

@humansinstitute - Please review when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant