Add sleep in UptimeRobot tests to get over free tier #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MuneebAijaz
commented
May 30, 2024
•
MuneebAijaz
commented
- Free tier has 10requests/min limit, and our tests exceed that. adding sleep in tests to go into next minutes and distribute tests over mins
- comment out Alert Contact test since Free Tier doesnt allow to add Alert Contacts
|
@MuneebAijaz Image is available for testing. |
| @@ -387,39 +394,42 @@ func TestAddMonitorWithIncorrectValues(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestAddMonitorWithAlertContacts(t *testing.T) { | |||
| config := config.GetControllerConfigTest() | |||
| // disabling this test since Free Tier UptimeRobot doesnt allow to add Alert Contacts | |||
There was a problem hiding this comment.
Maybe we should have it as a toggle instead, depending on what version of UptimeRobot we use?
There was a problem hiding this comment.
Maybe we should have it as a toggle instead, depending on what version of UptimeRobot we use?
Actually, that cannot be verified because token is checked on runtime by the UptimeRobot website, about the access/tier the token has. so we will have to comment this test out for now
karl-johan-grahn
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.