Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to derive distribution properties from iterators #29

Open
hpux735 opened this issue Jul 19, 2022 · 2 comments
Open

Add support to derive distribution properties from iterators #29

hpux735 opened this issue Jul 19, 2022 · 2 comments

Comments

@hpux735
Copy link
Contributor

hpux735 commented Jul 19, 2022

This package is great, and it's most of what I need. However, there doesn't seem to be a way to give it an iterator and have it derive the distribution coefficients. For example, if you created a new Gaussian distribution, you could initialize it with an iterator over f64 and it would traverse the iterator and compute the mean and variance, which could then be used in later computation.

If there is interest in such a feature from the maintainer(s), and a desire to help shape the architecture of such a feature, I could take a crack at implementing it...

Let me know.

Thanks.

@IvanUkhov
Copy link
Member

Hello, sorry for the late response!

Yes, I suppose estimation of distribution parameters would fit this crate. One could try it out on, say, Gaussian and see what abstractions would be needed. I am just thinking that there could be several cases, such as with and without known variance, and it would be nice to find good common traits to use across the crate. Perhaps one could start with one trait that tackles all parameters that the distribution in question has.

Please feel free to open a PR to discuss if you have time.

@hpux735
Copy link
Contributor Author

hpux735 commented Dec 14, 2022

Hi there. That sounds good. Here's a PR I created with what I had in mind. Feedback is welcome #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants