URLs can contain hyphens

stackernews · Feb 14, 2025 · eda5b56 · eda5b56
1 parent 2222c8f
commit eda5b56
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/url.js b/lib/url.js
@@ -254,7 +254,7 @@ export function isMisleadingLink (text, href) {
       }
     } catch {}
 
-    if (/^\s*(\w+\.)+\w+/.test(text)) {
+    if (/^\s*([\w-]+\.)+\w+/.test(text)) {
       if (new URL(hrefUrl.protocol + text).origin !== hrefUrl.origin) {
         misleading = true
       }

diff --git a/lib/url.spec.js b/lib/url.spec.js
@@ -43,7 +43,8 @@ const misleadingLinkCases = [
   // if text might be a link to a different origin, it's misleading
   ['innocent.text', 'https://stacker.news/items/1234', true],
   ['https://google.com', 'https://bing.com', true],
-  ['www.google.com', 'https://bing.com', true]
+  ['www.google.com', 'https://bing.com', true],
+  ['s-tacker.news', 'https://snacker.news', true]
 ]
 
 describe('misleading links', () => {