Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: nested wildcards route identification #27

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

Tiagoperes
Copy link
Contributor

Addresses matching wildcards were always identified as the less specific route. The opposite should be true.

Example:

  • Given the routes:
    • Workspaces: /workspaces/*
    • Workspace: /workspaces/{workspaceId}/*
    • Stacks: /workspaces/{workspaceId}/stacks/*
  • And the address /workspaces/001/stacks
  • The route identified should be Stacks. Instead, it was Workspaces, because routes identified with wildcards were selected as soon as found.

This PR fixes this problem.

@Tiagoperes Tiagoperes merged commit 1c31511 into main Sep 9, 2024
3 checks passed
@Tiagoperes Tiagoperes deleted the fix/nested-wildcards-route-identification branch September 9, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants