Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: modular tree merge #22

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Fix: modular tree merge #22

merged 2 commits into from
Jun 21, 2024

Conversation

Tiagoperes
Copy link
Contributor

Fixes the following bug:

  1. Host starts. Works fine.
  2. Module A starts and add its navigation tree to the host. Works fine.
  3. Module B starts and add its navigation tree to the host. The host's navigation tree doesn't change.

Actual problem: the algorithm to merge trees wasn't updating the reference to the parent after merging a route into a tree.

@Tiagoperes Tiagoperes merged commit 41ff5ce into main Jun 21, 2024
3 checks passed
@Tiagoperes Tiagoperes deleted the fix/modular-tree-merge branch June 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanrodrigueszup renanrodrigueszup renanrodrigueszup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tiagoperes @renanrodrigueszup