Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP::update incorrectly returns false? #30

Open
carelgm opened this issue Feb 27, 2025 · 0 comments
Open

NTP::update incorrectly returns false? #30

carelgm opened this issue Feb 27, 2025 · 0 comments

Comments

@carelgm
Copy link

carelgm commented Feb 27, 2025

hi,

I have a problem with the function NTP::update.

Is it possible that this function incorrectly returns false.

bool NTP::update() {
if ((millis() - lastUpdate >= interval) || lastUpdate == 0) { // 1||1; 1||0; 0||1; all indicate a need to update.
return ntpUpdate();
} // if there is no reason to update the result is 'ok' so return true.
return false should return true.
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant