Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Hotfix registration #1561

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

davidreneuw
Copy link
Contributor

There was an issue that prevented users from logging in the first time after registering. After registering, the user account exists in the tenant, but there is no portal user created for them just yet. Because of that, the current flow for checking if a user needs to register first when they attempt to login was redirecting them to the registration page upon their first login.

This PR adds an extra step that checks if their user account exists in the tenant, and if it does, proceeds to normal login flow.

Here's the flow:

flowchart TD
    A[User attempts to login] --> B{Check if associated PortalUser exists}
    B -->|Exists and Locked| C[Redirect to locked page]
    B -->|Exists and Deleted| D[Redirect to registration page with deleted state]
    B -->|Exists| E[Redirect to Microsoft login]
    B -->|Does not exist| F{NEW: Check if Entra ID account exists in the tenant}
    F-->|Exists| E
    F-->|Does not exist| H[Redirect to registration page with new user state]
Loading

Copy link
Contributor

@Sean-Stilwell Sean-Stilwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@ErikApption ErikApption merged commit 3784d98 into proof-of-concept Feb 14, 2025
14 checks passed
@ErikApption ErikApption deleted the hotfix/login-and-register branch February 14, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants